Fix bug letting already logged in users see login and forgot password forms #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following validation *validates_each :username* was causing multiple actions that operate on a user to fail, throwing a 500 error. This was preventing the inactive-user user account from being created by *rake db:seed* as well as preventing the inactive-user user to reset their password.
The error was caused by *user1* trying to log in while *user* was already logged in.
…n/forgot_password
This reverts commit 4a8b75e.
thomasdziedzic
suggested changes
Sep 4, 2019
There was a problem hiding this comment.
Overall I think you have a good PR which just needs some minor changes.
Note that there is another PR which solves part of what this PR is solving at #727
|
Thomas, thanks for jumping in to guide this PR, I appreciate you working through it with arandomandy. |
pushcx
reviewed
Sep 11, 2019
|
Thanks for taking this on. It's satisfying to squash these small bugs. If you bring in @thomasdziedzic's suggestion for the logout test, this is ready to merge. |
|
Deployed this fix. Thanks for contributing so many, and thanks to @thomasdziedzic for puzzling out our test issue. |
pushcx
pushed a commit
that referenced
this pull request
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.