Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly redirect json requests for a merged story's show page #710

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Properly redirect json requests for a merged story's show page #710

merged 2 commits into from
Jul 31, 2019

Conversation

pmueller
Copy link
Contributor

Attempt to fix #706.

Using the example from the bug report, a request to https://lobste.rs/s/2ftw37.json will now return a 302 to https://lobste.rs/stories/sfo06b.json

@pushcx
Copy link
Member

pushcx commented Jul 31, 2019 •
edited
Loading

Thanks for this bugfix. Looks like rubocop has a couple small style gripes, but I look forward to merging this after.

@pmueller
Copy link
Contributor Author

Sorry, forgot about rubocop! Should be cleaned up now

@pushcx pushcx merged commit bd1a303 into lobsters:master Jul 31, 2019
pushcx pushed a commit that referenced this pull request Jan 7, 2022
@pmueller @pushcx
Redirect json requests for a merged story's show page (#710)
eaa5cba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pmueller @pushcx