Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Unkind" option #663

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add "Unkind" option #663

merged 1 commit into from
Sep 26, 2019

Conversation

monokrome
Copy link
Contributor

@monokrome monokrome commented Apr 22, 2019

Add a new option "Unkind" when down-voting comments.

As brought up here: https://lobste.rs/s/xnjo8g/add_downvote_reason_unkind

As mentioned in https://lobste.rs/s/xnjo8g/add_downvote_reason_unkind#c_0lzrxb, this is maybe related to #376?

Does the phrasing need to be 100% figured out before any merging? The intent - which seems generally clear - seems important, and if it's being stored as a single character then we can easily adjust language as necessary later?

Note: I used "me-too" as a search term to see if there are any specific tests for this, and the me-too case didn't seem to have any. So, no tests here but happy to add some if people have ideas for what is testable here!

Also, I'm wondering if this requires consideration here?

votes.reason != 'M') > 2") # Me-Too comments rarely need attention

Add a new option "Unkind" when down-voting comments.

As brought up here: https://lobste.rs/s/xnjo8g/add_downvote_reason_unkind

Note: I used "me-too" as a search term to see if there are any specific tests for this, and the me-too case didn't see to have any. So, no tests here but happy to add some. Also, wondering if this requires modifications here? https://github.com/lobsters/lobsters/blob/d2963d4b80b47ac9f34bda65154a37cdde0a2174/app/controllers/mod_controller.rb#L33
@arp242
Copy link
Contributor

arp242 commented Apr 23, 2019

My 2¢ on this is that this may not actually be that useful. You can already downvote comments that are excessively hostile ("troll").

I think the key issue is tracking long-term consistently abrasive people. Everyone is a bit too abrasive sometimes, and that's kind of okay. The problem is usually a small minority who are abrasive a lot of the time.

Also see my comments here:

So I would prefer a different patch which adds a new "unkind" flag mechanism. This wouldn't -1 a post, just track it so a user's profile page can show something like 476 unkind flags (23% of total posts, and/or a special admin page with users with the most unkind flags.

I know this is a bit more work, but IMHO it's also much more useful.

@spacejam
Copy link

This seems to have quite a lot of support. One reason I think it should be a -1 is that we should rank objectively true yet unkind posts below objectively true posts that contain less toxicity. Avoiding a special case for this flavor of community-degrading content keeps the system easier to maintain and improve over time.

@pushcx pushcx force-pushed the master branch 3 times, most recently from acf676b to 316d894 Compare April 24, 2019 03:37
@pushcx
Copy link
Member

pushcx commented Apr 24, 2019

I ran out of review time this morning, will try to make time an evening this week.

@danielcompton
Copy link

danielcompton commented Apr 29, 2019

One reason I think it should be a -1 is that we should rank objectively true yet unkind posts below objectively true posts that contain less toxicity. Avoiding a special case for this flavor of community-degrading content keeps the system easier to maintain and improve over time.

I agree with this. I'm not in favour of adding a special flag for unkind comments that avoids downranking the comment. I looked back through the meta posts to see what the next most highly ranked thread was. It was the passing the torch post from jcs over a year ago. Looking at the comment threads on the unkind downvote reason post, more people were in favour of adding this flag than against it, at roughly a 2:1 or 3:1 ratio.

I do like the idea of showing a user their aggregate comment history and downvote percentages, possibly alongside the quartiles of active Lobsters commenters so you have some context to put the numbers in. However I don't think this needs to block this much smaller PR.

@monokrome
Copy link
Contributor Author

monokrome commented May 1, 2019

For what it's worth, I think that the value of a post is denoted just as much by how it affects people in as well as from whether something is true or not as well.

Like your example, if there were two posts with similar true content, I'd hope that the person who isn't calling people "idiots" or being otherwise abusive would have better karma. Just adding my agreement, and I'd be totes happy to change it in whichever direction makes the most sense to y'all, though 💟

@monokrome
Copy link
Contributor Author

@Carpetsmoker I think that "troll" is different than "unkind". Trolls are generally intending to aggro someone, while people may be "unkind" and not "trolling". I think that if we want "troll" to account for this, then maybe "troll" is a poor choice of words, but I can also see enough semantic difference that it may be valuable to separate the two? 🤷‍♀

@monokrome
Copy link
Contributor Author

Meow? 😸

@pushcx pushcx force-pushed the master branch 2 times, most recently from 5658fc8 to 6d9bd0f Compare June 12, 2019 21:43
@monokrome
Copy link
Contributor Author

@Carpetsmoker @arp242 @danielcompton Hey! Where is this at?

@danielcompton
Copy link

I think this would be a great addition to Lobsters, I’d love to see it added.

@angersock
Copy link

angersock commented Jul 8, 2019

It's come up a couple of times in the past couple of years, and still hasn't been implemented. Maybe come back next year and try again. :)

FWIW I think it'll just lead to abuse and damage the community, but I've covered that elsewhere.

@angersock
Copy link

angersock commented Jul 8, 2019

Does the phrasing need to be 100% figured out before any merging? The intent - which seems generally clear - seems important, and if it's being stored as a single character then we can easily adjust language as necessary later?

In the intervening time since filing, have we made any progress on the definition of the "unkind" flag? With that in hand it'd probably be a lot easier to carry it into a meta thread again. Otherwise, it's may be (rightly) criticized as pulling a fast one.

EDIT: To help this get better attention and input, created Lobsters survey.

@pushcx
Copy link
Member

pushcx commented Sep 26, 2019

Added

@pushcx pushcx merged commit 9d9c79d into lobsters:master Sep 26, 2019
@pushcx
Copy link
Member

pushcx commented Oct 7, 2019

Some kind of bug occurred - this isn't appearing. It's in Vote::COMMENT_REASONS in prod console but not prod js. Not sure what's wrong here. I manually ran RAILS_ENV=production bundle exec rails assets:precompile in prod and it didn't appear.

@danielcompton
Copy link

Hmm, this is curious. For others following along, this should be injected into the JS by:

commentDownvoteReasons: { <%= Vote::COMMENT_REASONS.map{|k,v|
"#{k.inspect}: #{v.inspect}" }.join(", ") %> },

@pushcx
Copy link
Member

pushcx commented Jan 2, 2020

...huh, this has gone live. First flag of a comment for being unkind happened at 2019-12-27 14:42:18. I don't know what would've unstuck this on that day, the code changes I merged + pushed were minor and unrelated. Maybe the 'bundle update' that would've gone with 57e0010 bounced unicorn and the constant wasn't refreshed? I don't like not understanding this.

@monokrome monokrome deleted the feature-comment-vote-reason-unkind branch June 23, 2020 05:26
@monokrome
Copy link
Contributor Author

monokrome commented Jun 23, 2020

I wonder what happened... Maybe it was a caching thing? 🤔

pushcx pushed a commit that referenced this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants