Average karma in user profiles #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about putting it in parenthesis next to the total karma like " (average 1.50)" User#stories_submitted_count and #comments_posted_count should probably have some caching since they would have to be pulled twice to generate that page. |
|
I like the parenthesis idea - seems cleaner - I just added it. As far as caching goes, rails should be caching those quereis - the caching is working properly on my local machine anyway. |
chobeat
referenced
this pull request
in gambe-ro/lobsters
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that I liked about the profiles on HN was the average karma - it can be a good way to gauge an individual's quality of contribution in some circumstances. I've added a field for average karma in user profiles like so: