Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup #1327

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Improve setup #1327

merged 3 commits into from
Sep 24, 2024

Conversation

edwardloveall
Copy link
Contributor

Hi. I was setting up the codebase this morning and struggled a bit as I don't have a lot of mysql experience. I took some steps to get it working, and then updated some README/code:

  • Add instructions to start the mysql server
  • Add instructions to set the root password to match database.yml.sample
  • Use the db:setup command in bin/setup. It does the same thing and will be a little faster since it doesn't have to load the rails app for three commands.

Totally open to feedback if there's a more idiomatic way to set up local mariadb.

* Add instructions to start the `mysql` server
* Add instructions to set the root password to match
`database.yml.sample`
* Use the `db:setup` command in `bin/setup`
Copy link
Member

@pushcx pushcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping improve the first time setup. I have a couple small tweaks and I look forward to merging this soon.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pushcx pushcx merged commit d8e7def into lobsters:master Sep 24, 2024
4 checks passed
@pushcx
Copy link
Member

pushcx commented Sep 24, 2024

Thanks for contributing back based on your experience. I'm (mumble) years past my first-run experience so I can't see these details very well anymore. You've helped future contributors here.

@edwardloveall edwardloveall deleted the el-setup branch September 28, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants