Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message for hat approvals #1111

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Message for hat approvals #1111

merged 1 commit into from
Jul 20, 2022

Conversation

saksham-jain
Copy link
Contributor

  • Common reason box for hat approval and rejection.
  • Change the reason box param name from rejection_comment to reason.
  • Change approve_by_user! to approve_by_user_for_reason! with reason param.

@saksham-jain saksham-jain mentioned this pull request Jul 19, 2022
Closed
@pushcx
Copy link
Member

pushcx commented Jul 20, 2022

Your screenshot looks great, I really appreciate that you took this on. I like that you renamed this function.

I'm going to merge this because it works correctly, but there's an opportunity for improvement I didn't realize when I filed #1110. HatsController doesn't use the strong params feature to protect against abuse. It's using params in a safe way now, but it'd be great to use the tool to make sure it stays safe. Would you like to take that, or should I file a separate issue for whoever comes along?

@pushcx pushcx merged commit b5c9332 into lobsters:master Jul 20, 2022
@saksham-jain
Copy link
Contributor Author

Your screenshot looks great, I really appreciate that you took this on. I like that you renamed this function.

I'm going to merge this because it works correctly, but there's an opportunity for improvement I didn't realize when I filed #1110. HatsController doesn't use the strong params feature to protect against abuse. It's using params in a safe way now, but it'd be great to use the tool to make sure it stays safe. Would you like to take that, or should I file a separate issue for whoever comes along?

Thanks, @pushcx. Surely I will pick it up and fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saksham-jain @pushcx