Removing jQuery from 7 more functions. #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding work done while waitting for the last pull request to be accepted
pushcx
requested changes
Jul 17, 2022
| fetchWithCSRF('/comments/' + li.getAttribute('data-shortid') + '/disown', { | ||
| method: 'post' | ||
| }) | ||
| .then(response => response.text()) |
There was a problem hiding this comment.
elsewhere you do response => response.text().then(text => ...
Is there a reason this one's different?
There was a problem hiding this comment.
Honestly, this is easier for me to read,
.then(response => response.text())
.then(text => replace(li, text));
with each line independent of the other. If I was doing a cleanup commit I would convert them all to this formant. But I will shift it back to the other format.
| } | ||
|
|
||
| // Inserts "> " on quoted text. | ||
| let sel = document.getSelection().toString() || ''; |
There was a problem hiding this comment.
Suggested change
| let sel = document.getSelection().toString() || ''; | |
| let sel = document.getSelection().toString(); |
getSelection always returns an object which returns here '' if nothing is selected
| let sel = document.getSelection().toString() || ''; | ||
| if (sel != "") { | ||
| sel = sel.split("\n").map(s => "> " + s + '\n').join(''); | ||
| sel += "\n"; |
There was a problem hiding this comment.
Suggested change
| sel += "\n"; | |
| sel += "\n\n"; |
We previously added two newlines after quoted text.
ymeynot45
force-pushed
the
jqueryless
branch
2 times, most recently
from
e32f0be to
bd35588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things amended to no longer require jQuery:
Bug Fixes
This leaves less than 1/2 dozen things to be replaced before we can remove the jQuery library.