Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign forms and user profile using CSS grid #1279

Open
pushcx opened this issue May 24, 2024 · 1 comment
Open

Redesign forms and user profile using CSS grid #1279

pushcx opened this issue May 24, 2024 · 1 comment

Comments

@pushcx
Copy link
Member

pushcx commented May 24, 2024

All of the site forms and the user profile display use a CSS design pattern of having fixed-width (7em) labels that float: left;. This is a fairly brittle design and has caused many bugs with content overlapping the labels (#1278), wide content breaking onto new lines, form fields that don't fill the width correctly*, etc. It feels like once or twice a year that an edit introduces a layout bug.

Since the site was created, CSS has gained a grid layout that's the perfect tool for this job. (Well, probably! It's certainly possible there's something even better I'm unaware of.) A grid layout would allow us to directly express this idea that there's a column of labels matched with a column of fields, and then on mobile the labels appear above the fields.

This is a pretty good-sized redesign, if anyone would like to contribute. I guess the first step would be to make a checklist of the site forms and user profile, then work down through it with one or more PRs. There are a couple forms that use space a little differently (/search but this is probably not an intentional inconsistency. The two complex forms are (/settings (so many fields and sections!) and the inline comment form (changes width based on reply depth).

Maybe there's the opportunity for more design improvements that are in keeping with the site's pretty plain look, relying on native widgets.

  • My current view in Firefox (desktop with a narrow window to see the mobile layout):

2024-05-24_16-46

@amu1996
Copy link

amu1996 commented Oct 16, 2024

@pushcx I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants