Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ’„ style: improve model config modal #5438

Merged
merged 4 commits into from
Jan 14, 2025
Merged

๐Ÿ’„ style: improve model config modal #5438

merged 4 commits into from
Jan 14, 2025

Conversation

arvinxx
Copy link
Contributor

@arvinxx arvinxx commented Jan 14, 2025 •
edited
Loading

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  • ไผ˜ๅŒ–ๆจกๅž‹ๆ–ฐๅขžๅ’Œ็ผ–่พ‘้ขๆฟ็š„้…็ฝฎ

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

refs: #5327 (comment)

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-database โœ… Ready (Inspect) Visit Preview Jan 14, 2025 4:58pm
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Jan 14, 2025 4:58pm

@lobehubbot
Copy link
Member

๐Ÿ‘ @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@arvinxx arvinxx changed the title improve model config modal ๐Ÿ’„ style: improve model config modal Jan 14, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Model Provider ๆจกๅž‹ๆœๅŠกๅ•† labels Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 93.09%. Comparing base (b7edbd3) to head (de4a58f).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5438      +/-   ##
==========================================
- Coverage   93.09%   93.09%   -0.01%     
==========================================
  Files         631      631              
  Lines       55423    55371      -52     
  Branches     4241     4283      +42     
==========================================
- Hits        51595    51545      -50     
+ Misses       3828     3826       -2
Flag Coverage ฮ”
app 93.09% <รธ> (-0.01%) โฌ‡๏ธ
server 97.99% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 14, 2025
@arvinxx arvinxx merged commit 9b303e0 into main Jan 14, 2025
11 checks passed
@arvinxx arvinxx deleted the style/improve-form branch January 14, 2025 17:03
@lobehubbot
Copy link
Member

โค๏ธ Great PR @arvinxx โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.45.13 [skip ci]
1f9e86e 
### [Version&nbsp;1.45.13](v1.45.12...v1.45.13)
<sup>Released on **2025-01-14**</sup>

#### ๐Ÿ’„ Styles

- **misc**: Improve model config form modal.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **misc**: Improve model config form modal, closes [#5438](#5438) ([9b303e0](9b303e0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.45.13 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jan 14, 2025
@semantic-release-bot
๐Ÿ”– chore(release): v1.87.7 [skip ci]
99a964b 
### [Version&nbsp;1.87.7](v1.87.6...v1.87.7)
<sup>Released on **2025-01-14**</sup>

#### โ™ป Code Refactoring

- **plugin**: Update plugin prompt.
- **misc**: Improve ai provider code.

#### ๐Ÿ› Bug Fixes

- **misc**: Fix `enable_search` parameter intro condition in Qwen, fix pull models error in new ai provider, fix some providers  issues, support Gemini 2.0 HarmBlockThreshold.

#### ๐Ÿ’„ Styles

- **misc**: Improve model config form modal.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **plugin**: Update plugin prompt, closes [lobehub#5083](https://github.com/bentwnghk/lobe-chat/issues/5083) ([ddd3b53](ddd3b53))
* **misc**: Improve ai provider code, closes [lobehub#5442](https://github.com/bentwnghk/lobe-chat/issues/5442) ([32013b4](32013b4))

#### What's fixed

* **misc**: Fix `enable_search` parameter intro condition in Qwen, closes [lobehub#5297](https://github.com/bentwnghk/lobe-chat/issues/5297) ([0b19c20](0b19c20))
* **misc**: Fix pull models error in new ai provider, closes [lobehub#5441](https://github.com/bentwnghk/lobe-chat/issues/5441) ([1726d85](1726d85))
* **misc**: Fix some providers  issues, closes [lobehub#5429](https://github.com/bentwnghk/lobe-chat/issues/5429) ([b7edbd3](b7edbd3))
* **misc**: Support Gemini 2.0 HarmBlockThreshold, closes [lobehub#5422](https://github.com/bentwnghk/lobe-chat/issues/5422) ([4d1a4cd](4d1a4cd))

#### Styles

* **misc**: Improve model config form modal, closes [lobehub#5438](https://github.com/bentwnghk/lobe-chat/issues/5438) ([9b303e0](9b303e0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Model Provider ๆจกๅž‹ๆœๅŠกๅ•† released size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arvinxx @lobehubbot