Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo error in validation.ts #594

Open
danfercf1 opened this issue Sep 30, 2024 · 0 comments
Open

Typo error in validation.ts #594

danfercf1 opened this issue Sep 30, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@danfercf1
Copy link
Contributor

danfercf1 commented Sep 30, 2024

Describe the bug
In the method validateInvoice there is a typo error in the line 343, the file is validation.ts, but I'm thinking that method is not used anywhere.

In other case the line should be:

if (!("MIN_PAYMENT_AMT" in process.env)) throw Error("MIN_PAYMENT_AMT not found, please check .env file");

instead of:

if (!("MAIN_PAYMENT_AMT" in process.env)) throw Error("MIN_PAYMENT_AMT not found, please check .env file");

And there is some console.debug that weren't removed in the lines 392-394, and I'm not totally sure if the line 391 is doing the right validation, the result of a new Date is an Object

@grunch grunch added help wanted Extra attention is needed good first issue Good for newcomers labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants