Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db helpers to be used with timestamps #2627

Merged
merged 4 commits into from
Aug 6, 2024
Merged

fix: db helpers to be used with timestamps #2627

merged 4 commits into from
Aug 6, 2024

Conversation

dni
Copy link
Member

@dni dni commented Aug 6, 2024

those helpers are used in boltz extension and they did not take dates into consideration yet

those helpers are used in boltz extension and they did not take dates
into consideration yet
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.73%. Comparing base (235f8a6) to head (b88cab4).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2627      +/-   ##
==========================================
- Coverage   60.38%   59.73%   -0.66%     
==========================================
  Files          70       71       +1     
  Lines       10150    10304     +154     
==========================================
+ Hits         6129     6155      +26     
- Misses       4021     4149     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lnbits/db.py Show resolved Hide resolved
@motorina0
Copy link
Collaborator

LGTM, but unit tests fail

@prusnak
Copy link
Collaborator

prusnak commented Aug 6, 2024

added one commit with get_placeholder refactor as suggested by @motorina0

@dni dni merged commit daa4b92 into dev Aug 6, 2024
32 checks passed
@dni dni deleted the fix-db-helper branch August 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants