fix: random exceptions in logs in middleware #2608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2608 +/- ##
==========================================
+ Coverage 58.65% 60.37% +1.71%
==========================================
Files 70 70
Lines 10139 10137 -2
==========================================
+ Hits 5947 6120 +173
+ Misses 4192 4017 -175 ☔ View full report in Codecov by Sentry. |
dni
changed the title
motorina0
approved these changes
Jul 29, 2024
closes #2599 special thanks to bitkarrot for figuring that out, it was actually initialized twice, the decorator alone is enough! also was issue for first_install middleware
dni
force-pushed
the
bug-wouldblock-error
branch
from
670a384 to
1b06ff7
Compare
talvasconcelos
approved these changes
Jul 31, 2024
blackcoffeexbt
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2599
special thanks to bitkarrot for figuring that out, it was actually initialized twice, the decorator alone is enough!
also was issue for first_install middleware, manually tested it