Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download CSV and JSON,expandable sidebar, resizable LQ UI, new prices #287

Merged
merged 16 commits into from
Dec 21, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 21, 2024

Important

This pull request adds CSV/JSON download support, an expandable sidebar, resizable UI elements, updates LLM prices, and enhances the frontend build workflow.

  • Download Functionality:
    • Added support for downloading datasets and evaluations in CSV and JSON formats in route.ts files.
    • Updated DownloadButton component to handle multiple formats.
  • UI Enhancements:
    • Implemented expandable sidebar using Sidebar components in project-navbar.tsx.
    • Added resizable panels in evaluations.tsx and queue.tsx.
  • Data Initialization:
    • Replaced seed.json with initial-data.json for database initialization in instrumentation.ts.
    • Updated LLM prices and models in initial-data.json.
  • Build and Workflow:
    • Added fe-build-check.yml for frontend build checks on pull requests.
  • Miscellaneous:
    • Removed button-scroll-to-bottom.tsx and project-navbar-collapsed.tsx as part of cleanup.
    • Updated package.json dependencies and tailwind.config.js for styling improvements.

This description was created by Ellipsis for f43c1a2. It will automatically update as commits are pushed.

dinmukhamedm and others added 16 commits December 5, 2024 13:15
* blog on labeling queues

* fix python example
…#270)

* Refactor datatable component to include filter clearing functionality

* fix requested changes
* Refactor download route to support multiple file formats

* reducing unnecessery css

* adding requested changes

* fix requested changes

* build and lint check
* online evals blog

* updated

* updated
* tmp

* frontend: expandable sidebar

* fix: new logo, better props, email on expanded

* fix: smaller sidebar width, saving sidebar state to cookies, padding

* fix: server side cookie fetching for sidebar state

* chore: fixed indentation

* fix: font size lg

* chore: indentation

* fix: indent using spaces

---------

Co-authored-by: Robert Kim <skull8888888@gmail.com>
* actions: frontend build check on PR commits

* fix: disable faulty caching

* fix: native install pnpm step

* fix: specify pnpm version

* fix: specified cache dependency path

* chore: update version
* increase grpc payload limit and JSON payload limit

* type change

---------

Co-authored-by: Robert Kim <skull8888888@gmail.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f43c1a2 in 1 minute and 18 seconds

More details
  • Looked at 3758 lines of code in 47 files
  • Skipped 9 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. frontend/lib/types.ts:63
  • Draft comment:
    The DownloadFormat type is defined but not used in the codebase. Consider using it where applicable or removing it if unnecessary.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The DownloadFormat type and constant are defined in frontend/lib/types.ts, but the type is not used in the codebase. This could lead to confusion or redundancy if not addressed.
2. frontend/package.json:118
  • Draft comment:
    The @types/react-syntax-highlighter package is included, but there is no direct dependency on react-syntax-highlighter. Ensure that the main package is installed if these types are needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The package.json file has a dependency on @types/react-syntax-highlighter, but there is no direct dependency on react-syntax-highlighter. This could lead to issues if the types are not needed or if the main package is missing.
3. frontend/tailwind.config.js:102
  • Draft comment:
    There are two Tailwind configuration files (tailwind.config.js and tailwind.config.ts). Ensure that only one is used to avoid confusion or redundancy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The tailwind.config.js and tailwind.config.ts files have overlapping configurations. This could lead to confusion or redundancy if both are used in the project.

Workflow ID: wflow_cjdCKpTqeyMH53pU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 5cf0c46 into main Dec 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants