-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download CSV and JSON,expandable sidebar, resizable LQ UI, new prices #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* blog on labeling queues * fix python example
…#270) * Refactor datatable component to include filter clearing functionality * fix requested changes
* Refactor download route to support multiple file formats * reducing unnecessery css * adding requested changes * fix requested changes * build and lint check
* tmp * frontend: expandable sidebar * fix: new logo, better props, email on expanded * fix: smaller sidebar width, saving sidebar state to cookies, padding * fix: server side cookie fetching for sidebar state * chore: fixed indentation * fix: font size lg * chore: indentation * fix: indent using spaces --------- Co-authored-by: Robert Kim <skull8888888@gmail.com>
* actions: frontend build check on PR commits * fix: disable faulty caching * fix: native install pnpm step * fix: specify pnpm version * fix: specified cache dependency path * chore: update version
* increase grpc payload limit and JSON payload limit * type change --------- Co-authored-by: Robert Kim <skull8888888@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to f43c1a2 in 1 minute and 18 seconds
More details
- Looked at
3758
lines of code in47
files - Skipped
9
files when reviewing. - Skipped posting
3
drafted comments based on config settings.
1. frontend/lib/types.ts:63
- Draft comment:
TheDownloadFormat
type is defined but not used in the codebase. Consider using it where applicable or removing it if unnecessary. - Reason this comment was not posted:
Confidence changes required:50%
TheDownloadFormat
type and constant are defined infrontend/lib/types.ts
, but the type is not used in the codebase. This could lead to confusion or redundancy if not addressed.
2. frontend/package.json:118
- Draft comment:
The@types/react-syntax-highlighter
package is included, but there is no direct dependency onreact-syntax-highlighter
. Ensure that the main package is installed if these types are needed. - Reason this comment was not posted:
Confidence changes required:50%
Thepackage.json
file has a dependency on@types/react-syntax-highlighter
, but there is no direct dependency onreact-syntax-highlighter
. This could lead to issues if the types are not needed or if the main package is missing.
3. frontend/tailwind.config.js:102
- Draft comment:
There are two Tailwind configuration files (tailwind.config.js
andtailwind.config.ts
). Ensure that only one is used to avoid confusion or redundancy. - Reason this comment was not posted:
Confidence changes required:50%
Thetailwind.config.js
andtailwind.config.ts
files have overlapping configurations. This could lead to confusion or redundancy if both are used in the project.
Workflow ID: wflow_cjdCKpTqeyMH53pU
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This pull request adds CSV/JSON download support, an expandable sidebar, resizable UI elements, updates LLM prices, and enhances the frontend build workflow.
route.ts
files.DownloadButton
component to handle multiple formats.Sidebar
components inproject-navbar.tsx
.evaluations.tsx
andqueue.tsx
.seed.json
withinitial-data.json
for database initialization ininstrumentation.ts
.initial-data.json
.fe-build-check.yml
for frontend build checks on pull requests.button-scroll-to-bottom.tsx
andproject-navbar-collapsed.tsx
as part of cleanup.package.json
dependencies andtailwind.config.js
for styling improvements.This description was created by for f43c1a2. It will automatically update as commits are pushed.