Feat: Add ability to change the Gradio temp path for saving images. Added ability to clear Gradio temp files and folders on launch #1992
+67
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would understand if you don't want to include the delete functionality. I just included it since it's what I have been using on my local to keep the temp files off my drive. |
midareashi
changed the title
|
relates to #1932 where the file of private_logger.py is used as frontend output (but Gradio still somehow creates temp images, even when prividing a filepath) |
|
@midareashi can you please pull the current main branch into this PR and fix merge conflicts? |
# Conflicts: # launch.py # modules/config.py
also use fallback to system temp dir see https://github.com/gradio-app/gradio/blob/6683ab2589f9d8658e1f51acc1b7526edce988d3/gradio/utils.py#L1151
mashb1t
added a commit
that referenced
this pull request
Mar 10, 2024
* Added options to set the Gradio cache path and clear cache on launch. * Renamed cache to temp * clear temp * feat: do not delete temp folder but only clean content also use fallback to system temp dir see https://github.com/gradio-app/gradio/blob/6683ab2589f9d8658e1f51acc1b7526edce988d3/gradio/utils.py#L1151 * refactor: code cleanup * feat: unify arg --temp-path and new temp_path config value * feat: change default temp dir from gradio to fooocus * refactor: move temp path method definition and configs * feat: rename get_temp_path to init_temp_path --------- Co-authored-by: Magee <koshms3@gmail.com> Co-authored-by: steveyourcreativepeople <steve@yourcreativepeople.com> Co-authored-by: Manuel Schmid <manuel.schmid@odt.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the temp path is a feature requested by several users. I doubt a lot of users even know Gradio is filling up their appdata folder with temporary images each time they generate. In the future it would be nice to use the image generated in private_logger.py for the completed image and get rid of the duplicate images entirely. Until then...
Delete on launch will only happen when using a custom Gradio Temp path. That will stop this app from removing Gradio Temp images created by other applications.
EDIT @mashb1t: relates to #1924