-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add advanced parameter for disable_intermediate_results (progress_gallery) #1013
Merged
mashb1t
merged 7 commits into
lllyasviel:develop
from
mashb1t:feature/add-advanced-parameter-disable-intermediate-images
Feb 24, 2024
Merged
add advanced parameter for disable_intermediate_results (progress_gallery) #1013
mashb1t
merged 7 commits into
lllyasviel:develop
from
mashb1t:feature/add-advanced-parameter-disable-intermediate-images
Feb 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4
…d-parameter-disable-intermediate-images
based on default and selected performance
…ble-intermediate-images
This was referenced Dec 29, 2023
Closed
This was referenced Jan 6, 2024
Open
Draft
Tested this commit directly the last few days: It works to not show the intermediate results as expected. But it doesnt help to work around the UI issues (linked in the mentioning issues). UI still hangs and shows errors / times out. Maybe there is just on button needed "Reconnect to Websocket" somewhere. Cause when the UI hangs in the wrong state you only can do a full reload and lose all your settings. |
…ble-intermediate-images # Conflicts: # modules/advanced_parameters.py
…termediate-images # Conflicts: # modules/advanced_parameters.py # webui.py
mashb1t
added a commit
that referenced
this pull request
Feb 25, 2024
…ss_gallery) (#1013) * add advanced parameter for disable_intermediate_results prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4 * update disable_intermediate_results correctly based on default and selected performance * chore: add missing translations
mashb1t
added a commit
that referenced
this pull request
Feb 25, 2024
…ss_gallery) (#1013) * add advanced parameter for disable_intermediate_results prevents gradio frontend process from clogging image output and updates in high throughput scenarios such as LCM with image number >= 4 * update disable_intermediate_results correctly based on default and selected performance * chore: add missing translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
prevents gradio frontend process from clogging image output of progress_gallery in high throughput scenarios such as LCM with image number >= 4