This repository has been archived by the owner on Oct 27, 2019. It is now read-only.
Update Sender.php #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The \InvalidArgumentException should be thrown on empty($registrationId) instead of is_null($registrationId) because a empty variable is not valid as $registrationId.
|
Could you also change the thrown exception's message to match this change? |
Updated Exception message to match exception
|
Ofcource, should be fine now :-) |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The \InvalidArgumentException should be thrown on empty($registrationId) instead of is_null($registrationId) because a empty variable is not valid as $registrationId.