Leonardo Pin & Self Test for RC522 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! First time I wrote the response here I was going to suggest you to rather send this to upstream, but it seems to me now that we have diverged completely. I was going to ensure that my changes where good and then send a PR to upstream, but it seems they have already received a PR from someone else and accepted. It is going to be too much work to get my branch compatible with their repo now, so this branch is here to stay. Thanks for the changes! |
ljos
added a commit
that referenced
this pull request
Dec 15, 2013
Leonardo Pin & Self Test for RC522
|
Also added you as a collaborator if you want to do other changes later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added pin instructions for Leonardo and code to run the digital self test on the RC522. Feel free to take whatever you like. No hard feelings if you don't want any of it. Best wishes, Claus.