Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register Errors wrong #5

Closed
konsgn opened this issue Jan 14, 2015 · 1 comment
Closed

Register Errors wrong #5

konsgn opened this issue Jan 14, 2015 · 1 comment

Comments

@konsgn
Copy link
Collaborator

konsgn commented Jan 14, 2015

in MFRC522.cpp line 294 it should read:

if(!(readFromRegister(ErrorReg) & 0x1D)) { // BufferOvfl Collerr CRCErr ProtocolErr

0x1D properly masks out the error bits in that register not 0x1B

0x1B caused problems with parity bit error that was not valid in the use case.
ljos pushed a commit that referenced this issue Jan 14, 2015
@konsgn @ljos
Fix [#5]: Register errors are wrong
d427494 
0x1D properly masks out the error bits in that register not 0x1B. 0x1B
caused problems with parity bit error that was not valid in the use
case.
@ljos ljos closed this as completed Jan 14, 2015
@ljos
Copy link
Owner

ljos commented Jan 14, 2015

Thank you.

Add you as a collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ljos @konsgn