Add support for on-the-fly document upgrades #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also addresses #2430 |
|
@pictos Thanks for the review, how did that slip through, that its a breaking change 😅 So in my latest commit i added a deserialization hook. Upsides:
Downsides:
|
pictos
reviewed
Jun 6, 2024
Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
|
Some tests failed before which are succeding (not the tests i touched)...sooo... @pictos Can we merge? 😅 |
mbdavid
approved these changes
Jul 3, 2024
| @@ -78,6 +96,15 @@ public T Deserialize<T>(BsonValue value) | |||
| /// </summary> | |||
| public object Deserialize(Type type, BsonValue value) | |||
| { | |||
| if (OnDeserialization is not null) | |||
| { | |||
| var result = OnDeserialization(this, type, value); | |||
There was a problem hiding this comment.
To keep consicise with all code base, let's use "this." for instance methods, properties and public fields (only private _ name has no "this.")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change would allow me to improve my library (https://github.com/JKamsker/LiteDb.Migration) significantly. The documents would then only be upgrades on load and not all at once.