Great! 😆

should it go directly into the undo stack, so you can easily undo it?

I would say yes, it would be helpful to be able to undo those changes

So, @jgmdev mentioned that there seems to be an issue here that was introduced when dmon introduced; basically if you're on a project that's at the file limit, autoreload doesn't actually reload things, because it's listening for dmon/dirmonitor events, even though those only fire on 'open' directories inside a project, and don't fire outside a project.

Solution here is to add a thread in the cases where we're looking at an external file, and add poll the file. There's also strong consensus around putting reload under doc directly; as several people would like this, so I'll move that over there as well.

OK; made those changes. Any thoughts? If none, I'll merge this as is on the 30th.

Testing with a file from outside the project, it looks like refusing the changes doesn't work.

Testing with a file from outside the project, it looks like refusing the changes doesn't work.

This is fixable by moving check_prompt_reload():

local on_check = dirwatch.check
function dirwatch:check(change_callback, ...)
  on_check(self, function(dir)
    for _, doc in ipairs(core.docs) do
      if dir == common.dirname(doc.abs_filename) then
        check_if_modified(doc)
      end
    end
    change_callback(dir)
  end, ...)
  check_prompt_reload() -- <--------------- from here
end

local on_check = dirwatch.check
function dirwatch:check(change_callback, ...)
  on_check(self, function(dir)
    for _, doc in ipairs(core.docs) do
      if dir == common.dirname(doc.abs_filename) then
        check_if_modified(doc)
        check_prompt_reload() -- <--------------- to here
      end
    end
    change_callback(dir)
  end, ...)
end

also shouldn't this coroutine: (wrong assumption)

      core.add_thread(function()
        while core.active_view.doc == doc do
          check_if_modified(doc)
          coroutine.yield(0.25)
        end
      end)

use an if instead like:

      core.add_thread(function()
        if doc and core.active_view.doc == doc then
          check_if_modified(doc)
        end
      end)

because using that while would keep it running far more than we desire doesn't?

Second Edit: seems that check_prompt_reload() also needs a call to update_time at least for files external to project

local function check_prompt_reload()
  if core.active_view.doc and core.active_view.doc.deferred_reload then
    local doc = core.active_view.doc
    core.nag_view:show("File Changed", doc.filename .. " has changed. Reload this file?", {
      { font = style.font, text = "Yes", default_yes = true },
      { font = style.font, text = "No" , default_no = true }
    }, function(item)
      if item.text == "Yes" then 
        reload_doc(doc) 
      else 
        update_time(doc) -- <----------------------- here 
      end
      doc.deferred_reload = false
    end)
  end
end

would be better to send that as a patch

would be better to send that as a patch

I did those checks on a rush and just posted what I found, here is a patch if it is right:

diff --git a/data/plugins/autoreload.lua b/data/plugins/autoreload.lua
index fba22a2..0882164 100644
--- a/data/plugins/autoreload.lua
+++ b/data/plugins/autoreload.lua
@@ -30,7 +30,11 @@ local function check_prompt_reload()
       { font = style.font, text = "Yes", default_yes = true },
       { font = style.font, text = "No" , default_no = true }
     }, function(item)
-      if item.text == "Yes" then reload_doc(doc) end
+      if item.text == "Yes" then
+        reload_doc(doc)
+      else
+        update_time(doc)
+      end
       doc.deferred_reload = false
     end)
   end
@@ -53,11 +57,11 @@ function dirwatch:check(change_callback, ...)
     for _, doc in ipairs(core.docs) do
       if dir == common.dirname(doc.abs_filename) then
         check_if_modified(doc)
+        check_prompt_reload()
       end
     end
     change_callback(dir)
   end, ...)
-  check_prompt_reload()
 end

OK; I actually realised there was an easier way to just cover all bases here; now that dirwatch is a modular class; we can actually just use that to efficiently check individual files outside the project, so that they too also reload with inotify.

I'm also going to target this PR at 2.1, because autoreload is straight broken in 2.1 at present.

OK, jgmdev tested this; seems to work. Squashing and merging.