Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDL to 2.0.20 #884

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Update SDL to 2.0.20 #884

merged 2 commits into from
Apr 20, 2022

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Mar 16, 2022

WrapDB updated SDL to 2.0.20 and with it got a lot set of configuration options.

@jgmdev
Copy link
Member

jgmdev commented Mar 16, 2022

I am unsure about:

* use_atomic

* use_threads

At least those two I need them for the threading plugin which I have poured some work into #830 and is now mature enough, which I have used to implement multi-threaded file search and threaded find project file for now. And the performance gains are measurable at least on my slower ARM64 box with 2T Cortex-A53 and 4T Cortex-A73

@Jan200101
Copy link
Contributor Author

force pushede to trigger the CI and detect some faults.

One find indicates we need to enabled events until the following issue is resolved.
libsdl-org/SDL#5413

@Jan200101
Copy link
Contributor Author

After a whole heap of 3 releases among which the entire meson.build had been reworked, OS and compiler specific bugs had been fixe and my will to live start my Windows VM had been completely depleted

This is ready

@Jan200101 Jan200101 marked this pull request as ready for review March 22, 2022 20:38
@takase1121 takase1121 mentioned this pull request Apr 11, 2022
@takase1121
Copy link
Member

I briefly tested this while testing #915 , works just fine.

@adamharrison adamharrison merged commit 915625b into lite-xl:master Apr 20, 2022
@adamharrison
Copy link
Member

OK, good enough for me. Resolving conflict and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants