Allow syntax patterns to match with the beginning of the line #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if `offset > 1` was used, the match would have failed because the beginning of the string was never met. Now we force the beginning of the string to be the one specified by the offset.
Before, syntax patterns/regexes that started with `^` didn't have the desired effect of matching with the start of the line. Now those patterns are used only when matching the whole line.
|
Tested and works perfectly for both patterns and regex, this should expand our options and lets us define syntax files without hacky workarounds when trying to match the beginning of lines, thanks for taking the time to fix this! Merging right away, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, syntax patterns that started with
^matched even when testing part of the line.Regexes worked because of how
^is handled in the PCRE2 implementation we're using: when an offset> 1is used,^never matches.This PR addresses the following points:
^with an offset> 1.That is,
^matches the beginning of the string as specified byoffset.^are now considered only when matching the whole line.