Added in support for fallback font groupings. #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, sample usage is like so: |
|
Should close #518 . |
|
Hey; I'm going to target this for a merge on the 20th, if no one has any objections. It's a fairly self-contained change, that shouldn't affect any existing code, so hopefully it's non-controversial enough to just merge in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in support for font groupings. Basically just reused the font metatable, but if on a table, will use those fonts as fallbacks if a glyph can't be found in the primary font. If a glyph still can't be found, will draw
U+25A1; the white square.Should close #591 .
Should close #611 .
Thoughts? I will likely be slimming this down if I can further.