Should close #558

I think we should probably also introduce the concept of a double and triple click, which would probably clean this up more. Will do that.

I compiled your code and tried adding this to my user module:

keymap.add {
  ["cmd+lclick"] = "lsp:goto-definition",
}

It's somehow working, but does not relocate the cursor soon enough to jump to the right definition. It's jumping where the cursor used to be before I perform the keymap.

However,

keymap.add {
  ["dlclick"] = "lsp:goto-definition",
}

Worked very well.

It's somehow working, but does not relocate the cursor soon enough to jump to the right definition. It's jumping where the cursor used to be before I perform the keymap.

I noticed a lot of modules don't follow the convention of actually reporting when they actually do something with user input, so this could be related to something like that. We probably just need to return true somewhere where we're not currently doing that. I'll look into it.

I noticed a lot of modules don't follow the convention of actually reporting when they actually do something with user input, so this could be related to something like that. We probably just need to return true somewhere where we're not currently doing that. I'll look into it.

Could this be solved by doing first keymap.on_mouse_pressed and then core.root_view:on_mouse_pressed?

Could this be solved by doing first keymap.on_mouse_pressed and then core.root_view:on_mouse_pressed?

I tried this, and it was not good. Basically left click is required to switch between active_views, and active_views consume commands. So if we put keymaps first, and the active view has a left click, you can't switch off that view. I think it does make more sense as-is.

Even with this current limitation that seem to affect only some plugins, this PR still makes the code better and more powerful.

OK, so added in mouse wheel into this as well (to simplify the scale plugin), and generalized clicks so that there's s, d and t prefixes for single, double and triple clicking; and a generalized click that just handles any amount of clicks which gets called last.

I think this is good to go. If no one has objections, I'd like to merge this by the 12th.

I wonder if instead of s d t we can use a number, like 123lclick

(%d*)([lrmxy]?)click

• %d* specify how much clicks, optional and default is 1
• [lrmxy]?specify which buttons: left, right, middle, mouse4, mouse5, optional and default is any

... That makes way more sense. OK. Will change that.

OK; I've incorporated @takase1121 's suggestions; now we use numeric prefixes (which makes way more sense); as well as allow for both optional click numbers, and optional button specifiers (and renamed x2 to y).

I've also added a config variable, config.max_clicks which specify at one point clicks wrap over. Prior to this PR, it was static at 3; but I think it makes sense to allow that to be a bit more flexible, for anyone who likes to spastically click like I do.

I'll merge this by the 16th if no further comments.