fix appimage cd error and use static appimage runtime #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takase1121
requested changes
Nov 14, 2024
Is there a specific reason behind it? I explained the switch to tab spaces due to the AppRun being made in the script. |
|
doing it for the AppRun specifically is fine, switching the indention for the entire file will cause conflicts with other PRs and doesn't fit the established pattern of spaces for indents |
|
You could simply unindent the heredoc declaration. |
takase1121
approved these changes
Nov 15, 2024
Guldoman
reviewed
Nov 15, 2024
|
https://github.com/Samueru-sama/lite-xl/actions/runs/11848568308/job/33020326874 Please fix this. UPDATE: nevermind this seems to be a temporary issue |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Nov 25, 2024
* fix appimage cd error and use static appimage runtime * include `desktop-file-utils` for appimagetool * remove mv of old `AppRun` * revert indentation * don't export `APPIMAGE_EXTRACT_AND_RUN`
takase1121
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix appimage cd error and use static appimage runtime * include `desktop-file-utils` for appimagetool * remove mv of old `AppRun` * revert indentation * don't export `APPIMAGE_EXTRACT_AND_RUN`
takase1121
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix appimage cd error and use static appimage runtime * include `desktop-file-utils` for appimagetool * remove mv of old `AppRun` * revert indentation * don't export `APPIMAGE_EXTRACT_AND_RUN`
takase1121
pushed a commit
that referenced
this pull request
Nov 27, 2024
* fix appimage cd error and use static appimage runtime * include `desktop-file-utils` for appimagetool * remove mv of old `AppRun` * revert indentation * don't export `APPIMAGE_EXTRACT_AND_RUN`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1912
However this won't fix the issue that the new builds of lite-xl don't use my user settings for some reason.
I also updated the appimage to use the new appimagetool that deploys the static appimage runtime, which gets rid of the libfuse2 dependency, however this means that the appimage will no longer work with appimagelauncher is right now it does not support the static appimage runtime.
I think the issue with libfuse2 is much more important since distros now don't ship libfuse2, but if you don't want that just let me know anyway. (Several other projects are switching to the static runtime regardless, most notably Cemu did it 2 years ago).
Also I removed the download of the generic AppRun and instead just made a simple one in the script, this is to avoid issues with the generic AppRun setting a lot of env variables that don't need to be set and would propagate to everything launched by lite-xl, like the terminal plugin, this is also why I changed the indentation to tabs to make the HEREDOC 😅