Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: Add proper platform-specific icon #1844

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

kra-mo
Copy link
Contributor

@kra-mo kra-mo commented Jun 30, 2024

Looks like this

icon_256x256@2x

@takase1121
Copy link
Member

Hey, thank you for the icon, do you perhaps have one for the disk image? Like these:
image

@takase1121
Copy link
Member

Did you make this icon manually, or is this generated with some utility?

@kra-mo
Copy link
Contributor Author

kra-mo commented Jul 2, 2024

 Did you make this icon manually, or is this generated with some utility?

I edited and packaged it manually.

  do you perhaps have one for the disk image?

I'd be willing to design one, give me a few minutes ^^

@kra-mo
Copy link
Contributor Author

kra-mo commented Jul 2, 2024

@takase1121 I created a .dmg icon ^^

dmg

@kra-mo
Copy link
Contributor Author

kra-mo commented Jul 2, 2024

I do not know how I might modify the existing build script to include it though, you're going to have to help me out with that 😅

@takase1121
Copy link
Member

I do not know how I might modify the existing build script to include it though, you're going to have to help me out with that 😅

Please export the file as dmg-icon.icns in resources/macos, and modify the path in

icon = "resources/icons/icon.icns"
to the file. You can push it and the CI will create a DMG with the correct icon.

@kra-mo
Copy link
Contributor Author

kra-mo commented Jul 4, 2024

Done ^^

@takase1121
Copy link
Member

takase1121 commented Jul 4, 2024

image
For other people's reference this is how it looks like. Looks fine for me but I'll wait for other opinions.

image
This is how it looks like on the dock.

@kra-mo
Copy link
Contributor Author

kra-mo commented Jul 4, 2024

(last force-push to address a slight misalignment I just noticed from your screenshot because I have my dock on the left)

@takase1121 takase1121 merged commit 5a427a8 into lite-xl:master Jul 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants