Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc): convert Doc:merge_cursors parameter from "selection index" to table index #1833

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(doc): convert Doc:merge_cursors parameter from "selection index" to table index #1833

merged 1 commit into from
Jun 24, 2024

Conversation

Guldoman
Copy link
Member

Fixes #1829.

@takase1121
Copy link
Member

Since this function is not used anywhere outside of DocView except core/init.lua, and no known plugins uses this function, I am considering this as fixing a regression and include it in the bugfix release.

@takase1121 takase1121 merged commit 7ca4c94 into lite-xl:master Jun 24, 2024
8 of 10 checks passed
@takase1121 takase1121 mentioned this pull request Jun 24, 2024
Merged
@Guldoman
Copy link
Member Author

For reference, I forgot a +1 at the end there 🤦. Fixed in #1834.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Lua Core
Projects
Bugfix Release Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some text may get mangled while typing with multicursors
2 participants
@Guldoman @takase1121