Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SerenityOS platform support #1745

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

Jan200101
Copy link
Contributor

No description provided.

@takase1121
Copy link
Member

takase1121 commented Mar 15, 2024

I'm just putting this out here: I am not opposed to adding C++ to the codebase at all. If some components needs C++ on certain platforms, then so be it. Lite XL is a C-based project, so it's not like C++ is going to replace anything. There is absolutely no reason to do everything in C if you end up pulling some dark magic, like manually creating vtables for COM on Windows.

meson.build Outdated Show resolved Hide resolved
@adamharrison
Copy link
Member

I don't like the C++, but I won't stand in the way of it.

@adamharrison adamharrison merged commit 5d264e1 into lite-xl:master Mar 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants