Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action dependencies #1724

Merged
merged 30 commits into from
Jun 7, 2024
Merged

Conversation

takase1121
Copy link
Member

This PR does a few things:

  1. Update the labeler action to remove warnings
  2. Make actions/setup-python fetch Python 3.11 instead of any 3.x.
  3. Update actions/upload-artifact and actions/download-artifact to v4, which requires some changes on artifact naming because you can no longer modify artifacts.
  4. Upload other artifacts as well

Is there any actual performance improvements from switching to v4? Not really, we don't upload alot of stuff anyway. I don't know if GitHub plans to deprecate v3 in the future, so I'm trying to future-proof this. It does make downloading artifacts better tho (now the zip files you downloaded won't be corrupt).

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the various compression-level for?

@takase1121
Copy link
Member Author

What are the various compression-level for?

They don't do much, they disable compression for already compressed files so it doesn't accidentally expand them.

@takase1121 takase1121 requested a review from Guldoman April 16, 2024 11:15
@takase1121 takase1121 force-pushed the ci/update-actions branch from e55e10a to 68bc105 Compare June 6, 2024 01:40
@takase1121
Copy link
Member Author

More updates to fix releases not generating correctly.

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mark the release as draft so that we can review it?

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/auto_labeler_pr.yml Outdated Show resolved Hide resolved
@takase1121 takase1121 requested a review from Guldoman June 6, 2024 14:24
@takase1121
Copy link
Member Author

Should we mark the release as draft so that we can review it?

The release is draft. I'm pretty sure it's because you can't see my draft releases.

https://github.com/takase1121/lite-xl/releases/tag/untagged-e977bab92eaa2f01efd3
image

@Guldoman
Copy link
Member

Guldoman commented Jun 6, 2024

The release is draft. I'm pretty sure it's because you can't see my draft releases.

Oh weird. Looking at the documentation I would have guessed it wouldn't be.
Alright then.

@Guldoman
Copy link
Member

Guldoman commented Jun 6, 2024

Ooooh it's likely because it gets created as draft by Create Release and Upload Release Artifacts just updates it.

@takase1121 takase1121 merged commit a17c7cf into lite-xl:master Jun 7, 2024
10 checks passed
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Jun 21, 2024
* CI: update various action versions

The most significant change is action/upload-artifact@v4,
which does not support uploading artifacts of the same name.
This makes our lives significantly worse, but I don't know
if GitHub will remove v3 in future or not.

* CI: fix macOS universal artifact download

* CI: update release action versions

* CI: use containers only for building

* CI: fix multiline commands

* CI: try to fix multiline strings again

* CI: fix multiline strings again ugh

* CI: Fix ccache in containers

* CI: Fix quotes again

* CI: fix ccache

* CI: fix deprecated set-output command

* ci: update build box to v2.1.2

* ci: revert to softprops/action-gh-release

* ci: add name to release

* ci: remove name again

* ci: fix wrong outputs reference

* ci: add name

* ci: add missing name for each step

* ci: format yaml files

* ci/release: add names to unamed entries

* ci/release: fix MSYS2 not downloading deps

* ci/release: change to ncipollo/release-action

There is some weird issue with softprops/action-gh-release and I can't update an existing release.

* ci/release: allow updating releases

* ci/release: upload all artifacts, then download them at once

* ci/release: use a better name for job

* ci/release: add release as dependency

* ci/release: set tag for update release

* ci/auto-labeler: remove workaround for old autolabeler issue

* ci/release: remove the need of another bash -c

* ci/release: remove weird bash -c
takase1121 added a commit that referenced this pull request Jun 23, 2024
* CI: update various action versions

The most significant change is action/upload-artifact@v4,
which does not support uploading artifacts of the same name.
This makes our lives significantly worse, but I don't know
if GitHub will remove v3 in future or not.

* CI: fix macOS universal artifact download

* CI: update release action versions

* CI: use containers only for building

* CI: fix multiline commands

* CI: try to fix multiline strings again

* CI: fix multiline strings again ugh

* CI: Fix ccache in containers

* CI: Fix quotes again

* CI: fix ccache

* CI: fix deprecated set-output command

* ci: update build box to v2.1.2

* ci: revert to softprops/action-gh-release

* ci: add name to release

* ci: remove name again

* ci: fix wrong outputs reference

* ci: add name

* ci: add missing name for each step

* ci: format yaml files

* ci/release: add names to unamed entries

* ci/release: fix MSYS2 not downloading deps

* ci/release: change to ncipollo/release-action

There is some weird issue with softprops/action-gh-release and I can't update an existing release.

* ci/release: allow updating releases

* ci/release: upload all artifacts, then download them at once

* ci/release: use a better name for job

* ci/release: add release as dependency

* ci/release: set tag for update release

* ci/auto-labeler: remove workaround for old autolabeler issue

* ci/release: remove the need of another bash -c

* ci/release: remove weird bash -c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants