Virtual Lines #1713
Draft
Virtual Lines #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah; I know. It's still broken, though. I've gotta fix it up. It's definitely on my radar, but my priority right now is #1455. They'll both go in for the same release, as they basically both necessitate breaking the plugin infrastructure. |
|
Thanks for answer. I wish you well in your efforts. We'll just need to wait some more :) |
…ugin, removed project limit, removed the concept of a project maintaining an ordered list of files, and allowed treeview to see things like hidden files and files not actually in the project. Normalizing things, fixed typo. Abstracted root project, and made things more in line with current master behaviour. Removed unused legacy code, as well as ensured that we use absolute paths. Fixed issue with backslahes on linux, will look at windows at some point. Removed stray print. Removed orphaned function. Removed extraneous command. Fixed the ability to close project folders. Removed superceded function. Applied jgm's suggestions.
…ugins can use it.
…et has_restarted.
…ion warnings for legacy interface.
Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
adamharrison
force-pushed
the
PR/virtual-lines
branch
3 times, most recently
from
6734274 to
9090c7c
Compare
Initial commit of virtual lines PR. Making it so that linewrapping also works. Things proceed apace. We proceed apace. Fixed many things. Fixed a number of bugs. Standardizing naming conventions. Fixed issue with resolving screen position on multi-lines. Added in read-only mode. Fixed selections. Gloriously beautiful. Uncommented modified selcetions. Rearranged things to be more abstracted. Fixed line length issue. Rearchitected token storage. Fixed invalidations. Hooked up highlighter to syntax highlighting. Added in rqeuest to tokenize extra lines. Reduced size. Bumped modversion. Fixed issue with cache not resizing appropriately. Changed over resolve_screen_position to new system. Mixed up order of parameters. Small little bug fixes. Ensure we don't wrap over. Removed dev statement. More small fixes. Fixed some codefolding and autocomplete issues. Fixed up plugins that still use doc.
adamharrison
force-pushed
the
PR/virtual-lines
branch
from
9090c7c to
52d7037
Compare
|
This is getting closer. We're nearly there. I've rebased this ontop of project rework; and have incorporated this into my daily driver lxl. It's near-stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, finally I've decided to take a crack at virtual lines. This'll make things like word wrapping, code folding, highlighting, and other things like that significantly easier to implement.
I've also moved most things like selections from
doctodocviewso we don't have the weird issue of spilt views sharing selections and other things like that.Overall it should be a wash in terms of the amount of code; it's basically just unifying the disparate ways of modifying tokens to be drawn into a single system that hopefully won't overly affect performance.
I've also bumped the modversion as this is going to break a lot of stuff; I've tried to keep the interfaces roughly the same, but it's just too big a refactor to not bump modversion.
Also includes a codefolding plugin to take advantage of the new system.