-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add system.setenv #1706
add system.setenv #1706
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also document the function in docs/api/system.lua
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can already implement returning the success status, but obviously SetEnvironmentVariableW
returns the exact opposite of setenv
so we need specific code for each...
Thank you! |
Resolves #1702
There's some potential expanding to do later, but the functionality works on POSIX-compatible systems as a minimum (I don't have a windows machine to test the win32 code, but from what I can tell it should be ok).