Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): ad-hoc sign macOS bundles #1656

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

takase1121
Copy link
Member

Fuck you, Apple.

This downgrades our application from "oh this app is damaged" to "oh this app is from an unknown developer". Why do we need to go through such hoops to do this? dunno.

@takase1121
Copy link
Member Author

Does not work.

@takase1121 takase1121 closed this Oct 27, 2023
@takase1121 takase1121 reopened this Oct 27, 2023
@takase1121
Copy link
Member Author

Or does it? You can now authorize it in System Settings.

@takase1121
Copy link
Member Author

This is the required steps to make it work:

https://support.apple.com/en-am/guide/mac-help/mh40616/mac

I will argue that its much better than the current process.

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh.

Do we need to update the README?

@takase1121
Copy link
Member Author

Yes. If someone could contribute some screenshots on a fresh install of macOS I'll really appreciate it; I literally have no storage for another macOS VM.

@takase1121 takase1121 requested a review from Guldoman November 9, 2023 14:59
README.md Outdated Show resolved Hide resolved
Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
@Guldoman Guldoman merged commit 332ea81 into lite-xl:master Nov 10, 2023
9 of 10 checks passed
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Nov 10, 2023
* feat(package): ad-hoc sign macOS bundles

* fix(package.sh): syntax error

* docs(readme): add instructions for self-signed builds

* docs(readme): grammar

Co-authored-by: Guldoman <giulio.lettieri@gmail.com>

---------

Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants