Ignore keypresses during IME composition #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some IMEs continue sending keypresses even during composition, so we just ignore them.
takase1121
approved these changes
Oct 18, 2023
|
In case this PR is merged, let's track the textinput problem in the issue tracker. |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Oct 18, 2023
Some IMEs continue sending keypresses even during composition, so we just ignore them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IMEs continue sending keypresses even during composition, so we just ignore them.
I'm moving this to be more generic (cause even some IMEs on Linux send the events, need to investigate more, might be an SDL issue), while still retaining mouse commands like scroll.
This is still not enough, as we're receiving some
textinputevents too while we should not, but we can't disable those because that's how we receive the final IME composition...