feat(core.emptyview): add name to emptyview #1569
Conversation
If we're not to show it, I'd just call it
We should probably make workspace loading more robust, and relayout if something fails to load. |
I don't really agree with this. I think the name should be end user friendly, and "Empty View" doesn't really describe the view. The View is a landing page for the editor, so "Get Started" would be more appropriate.
I agree, but this is still relevant since I think most views should have names. |
I mean my point was about it not being shown, so users would never see it. |
* feat(core.emptyview): add name to emptyview * fix(core.emptyview): set filename to empty
* feat(core.emptyview): add name to emptyview * fix(core.emptyview): set filename to empty
* feat(core.emptyview): add name to emptyview * fix(core.emptyview): set filename to empty
* feat(core.emptyview): add name to emptyview * fix(core.emptyview): set filename to empty
* feat(core.emptyview): add name to emptyview * fix(core.emptyview): set filename to empty
This has always been a nit for me; When plugins fail to load it always shows
---forEmptyView.This PR changes it to
Get Started. Maybe there are more suitable names, but I think this one's just fine.As a side effect, it also says
Get Startedwhen nothing is opened now. Perhaps it should return the current project name, etc. but I think this looks okay.