Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for core.command #1564

Merged
merged 9 commits into from
Jul 27, 2023
Merged

Conversation

takase1121
Copy link
Member

Closes #1503.

data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Show resolved Hide resolved
data/core/command.lua Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
data/core/command.lua Outdated Show resolved Hide resolved
@takase1121 takase1121 requested a review from Guldoman July 26, 2023 08:41
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify somewhere how the command name should be formatted?

data/core/command.lua Show resolved Hide resolved
@takase1121 takase1121 requested a review from Guldoman July 27, 2023 04:43
@Guldoman Guldoman merged commit 7955fa1 into lite-xl:master Jul 27, 2023
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
* docs(core.command): add documentation

* fix(core.common): fix warnings

* docs(core.command): add "core." prefix to all custom types

* docs(core.command); add name as parameter to command.perform

* docs(core.command): fix typo and wording

* docs(core.command): add disclaimer to command.generate_predicate

* docs(core.command): fix wording for predicate

* docs(core.command): document command name

* docs(core.command): document the always_true predicate
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
* docs(core.command): add documentation

* fix(core.common): fix warnings

* docs(core.command): add "core." prefix to all custom types

* docs(core.command); add name as parameter to command.perform

* docs(core.command): fix typo and wording

* docs(core.command): add disclaimer to command.generate_predicate

* docs(core.command): fix wording for predicate

* docs(core.command): document command name

* docs(core.command): document the always_true predicate
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
* docs(core.command): add documentation

* fix(core.common): fix warnings

* docs(core.command): add "core." prefix to all custom types

* docs(core.command); add name as parameter to command.perform

* docs(core.command): fix typo and wording

* docs(core.command): add disclaimer to command.generate_predicate

* docs(core.command): fix wording for predicate

* docs(core.command): document command name

* docs(core.command): document the always_true predicate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document core.command
2 participants