feat(src/renderer): stream fonts with SDL_RWops on all platforms #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guldoman
approved these changes
Jul 9, 2023
|
@adamharrison IIRC you said you wanted to use something like this in the AIO version, so I'll leave you the last review. |
This fixes lite-xl#1529 where the font itself carries the font file, which gets copied around. This commit streams the file, so the file is not entirely in memory.
takase1121
force-pushed
the
renderer/stream-font
branch
from
4aee539 to
c5ff184
Compare
takase1121
added a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
…e-xl#1555) * feat(src/renderer): stream fonts with SDL_RWops on all platforms This fixes lite-xl#1529 where the font itself carries the font file, which gets copied around. This commit streams the file, so the file is not entirely in memory. * style(src/renderer): use standard C types * refactor(src/renderer): implement FT_Stream.close * fix(src/renderer): fix SDL_RWops double free
takase1121
added a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
…e-xl#1555) * feat(src/renderer): stream fonts with SDL_RWops on all platforms This fixes lite-xl#1529 where the font itself carries the font file, which gets copied around. This commit streams the file, so the file is not entirely in memory. * style(src/renderer): use standard C types * refactor(src/renderer): implement FT_Stream.close * fix(src/renderer): fix SDL_RWops double free
takase1121
added a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
…e-xl#1555) * feat(src/renderer): stream fonts with SDL_RWops on all platforms This fixes lite-xl#1529 where the font itself carries the font file, which gets copied around. This commit streams the file, so the file is not entirely in memory. * style(src/renderer): use standard C types * refactor(src/renderer): implement FT_Stream.close * fix(src/renderer): fix SDL_RWops double free
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR loads the font file with SDL_RWops on all platforms. This will support UTF-8 filename on Windows without loading the entire file into memory, which partially causes #1529. The other part of the issue is with too much glyphsets loaded at once (and slow load), but this will reduce the memory used.
Partially fixes #1529.