Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1393 followup #1463

Merged
merged 3 commits into from
Apr 10, 2023
Merged

#1393 followup #1463

merged 3 commits into from
Apr 10, 2023

Conversation

vqns
Copy link
Contributor

@vqns vqns commented Apr 8, 2023

  • fix incorrect check in doc:remove sometimes resulting in incorrect selections
  • restore old behavior of leaving cursors in their original position when using the command doc:cut

@vqns
Fix incorrect check in doc:raw_remove
7c26c1b 
Restore caret position on command doc:cut
@Guldoman
Copy link
Member

Guldoman commented Apr 8, 2023

Seems like we'll have to merge the cursors at the end of the cut too.
Try cutting consecutive lines, then inserting some text. You'll have multiple cursors where there should be only one.

Guldoman
Guldoman reviewed Apr 8, 2023
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the newline thing, I think this is good to go.

I'll watch out for more changes needed to compensate us finally having proper caret movement on delete 😅.

data/core/commands/doc.lua Outdated Show resolved Hide resolved
@Guldoman Guldoman merged commit 1f1b7fc into lite-xl:master Apr 10, 2023
@Guldoman
Copy link
Member

Thank you!

takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@vqns @takase1121
lite-xl#1393 followup (lite-xl#1463)
f60228f 
* Fix incorrect check in doc:raw_remove

Restore caret position on command doc:cut

* merge cursors and fix new line in clipboard

* add new line to the last copied line
@Guldoman Guldoman mentioned this pull request Oct 23, 2023
Closed
@vqns vqns deleted the fix-raw-remove-and-cut branch March 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman left review comments

Assignees
No one assigned
Labels
Category: Lua Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vqns @Guldoman