Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the header into include/ #1440

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Conversation

takase1121
Copy link
Member

This allows people to compile by specifying -I../lite-xl/resources/include

@jgmdev
Copy link
Member

jgmdev commented Apr 11, 2023

Conflict since #1436 already moved resources/lite_xl_plugin_api.h to resources/include/. After fixing the conflict this PR should be merged.

@jgmdev
Copy link
Member

jgmdev commented Apr 11, 2023

As an observation partially related to this PR I believe that at least on linux lite_xl_plugin_api.h could be installed by meson into /usr/include or maybe to a separete lite-xl subdir as /usr/include/lite-xl/plugin_api.h (in case that in the future we ship more development header files). A pkgconfig file would not be necessary since placing the headers on /usr/include should be automatically picked by the compiler predefined include flags and plugins don't need to link against anything so far, so doing:

#include <lite_xl_plugin_api.h>
// or
#include <lite-xl/plugin_api.h>

should just work

@takase1121 takase1121 force-pushed the PR/move-header-file branch from e84930a to a97649c Compare April 13, 2023 00:42
@jgmdev jgmdev merged commit 3f8dedd into lite-xl:master Apr 14, 2023
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants