Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing MSYS2 CI #1435

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Optimizing MSYS2 CI #1435

merged 4 commits into from
Apr 7, 2023

Conversation

takase1121
Copy link
Member

This PR tries to reduce CI build times.

  1. MSYS2 updates are not run. This usually isn't necessary.
  2. Install MSYS2 packages in the setup phase. If you look at the workflow, MSYS2 packages installed when running in MSYS2 will not be cached since there is no post-build step.
  3. Download the subprojects before patching. This prevents meson from reconfiguring the project due to file changes.

@pegvin
Copy link
Contributor

pegvin commented Mar 18, 2023 •
edited
Loading

use:

    - uses: msys2/setup-msys2@v2
      with:
        ....
        release: true
        ....

to download and the latest msys2 version without needing to update

@takase1121
Copy link
Member Author

use:

    - uses: msys2/setup-msys2@v2
      with:
        ....
        release: true
        ....

to download and the latest msys2 version without needing to update

This is the default behavior thus it is omitted.

Note that it may be the latest release but not all packages are the latest.

Guldoman
Guldoman approved these changes Mar 18, 2023
View reviewed changes
.github/workflows/build.yml Show resolved Hide resolved
@jgmdev
Copy link
Member

jgmdev commented Apr 7, 2023

This has already been approved so why not merge it?

@jgmdev jgmdev merged commit 7eaa858 into lite-xl:master Apr 7, 2023
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@takase1121
Optimizing MSYS2 CI (lite-xl#1435)
c0aa593 
* feat(ci): install dependencies on setup
* fix(ci): don't update msys2 when setup
* fix(ci): download subprojects before patching
* doc(ci): document why meson subprojects download is called
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@takase1121
Optimizing MSYS2 CI (lite-xl#1435)
d11d12d 
* feat(ci): install dependencies on setup
* fix(ci): don't update msys2 when setup
* fix(ci): download subprojects before patching
* doc(ci): document why meson subprojects download is called
takase1121 added a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@takase1121
Optimizing MSYS2 CI (lite-xl#1435)
84aeea6 
* feat(ci): install dependencies on setup
* fix(ci): don't update msys2 when setup
* fix(ci): download subprojects before patching
* doc(ci): document why meson subprojects download is called
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman approved these changes

Assignees
No one assigned
Labels
Category: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takase1121 @pegvin @jgmdev @Guldoman