Improve text width calculation precision #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some extreme cases (~30000 chars) text width precision takes a hit. Using double instead of float fixes that.
Guldoman
force-pushed
the
PR_improve_text_width_precision
branch
from
f0b3af5 to
862a2da
Compare
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
In some extreme cases (~30000 chars) text width precision takes a hit. Using double instead of float fixes that.
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
In some extreme cases (~30000 chars) text width precision takes a hit. Using double instead of float fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some extreme cases (~30000 chars), text width precision takes a hit. Using double instead of float fixes that.
To repro the issue:
Another possible solution would be to force the tokenizer to split long strings, so that we never calculate the width of extremely long strings.
There might be a performance impact, but I haven't tested that yet.