NagView: properly rescale on scale change #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guldoman
reviewed
Feb 2, 2023
Comment on lines
+248
to
+256
| function NagView:on_scale_change(new_scale, old_scale) | ||
| BORDER_WIDTH = common.round(1 * new_scale) | ||
| UNDERLINE_WIDTH = common.round(2 * new_scale) | ||
| UNDERLINE_MARGIN = common.round(1 * new_scale) | ||
| self.target_height = math.max( | ||
| self:get_message_height(), | ||
| self:get_buttons_height() | ||
| ) | ||
| end |
There was a problem hiding this comment.
I wonder if it would be better to just move those values to their own function that calculates them on demand.
There was a problem hiding this comment.
It is actually more efficient to calculate at least self.target_height only when needed and not on each rendering pass or update.
There was a problem hiding this comment.
It would still only be called when the NagView is visible, and I'm sure the calculations required are not that complex, as the most complex thing needed is NagView:get_message_height which I'm just noticing could be simplified quite a bit.
Guldoman
reviewed
Feb 2, 2023
|
Merging this for now as the suggestions above are more a different way of doing things without any impact on the desired result. |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
* drop font option since style.font is always used
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
* drop font option since style.font is always used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides properly rescaling the NagView overlay on scale changes this PR also drops the font option because:
style.fontis always used on the core for the buttonsChecked the lite-xl-plugins repo and it seems no plugin is affected with the font option removal since none of the plugin is making use of core.nag_view
Before:
After:
