Improved plugins config table handling #1356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it supports automatically loading/requiring a previously disabled plugin by usingdropped because of concerns of loading priority issuesconfig.plugins.plugin_name = true
orconfig.plugins.plugin_name = {...}
Warns user if trying to disable a plugin that is already enabled when doing
config.plugins.plugin_name = false
and also prevents replacing the current plugin config table with the false value to mitigate runtime issues.Uses a merge strategy by default when assigning a table to a plugin config to prevent a user from removing a plugin default config values as experienced and explained on this issue settings disables the drawwhitespace plugin lite-xl-plugins#158
This change is basically backwards compatible, but will require a change on the settings ui plugin on how it checks for already enabled plugins, since rawget will no longer be a working hack or workaround for this.