plugin api: allow usage on multiple source files #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with Adam on discord current Lite XL Lua Plugin API was not working on native plugins with more than 1 source file since imported symbols were not exposed to other unit files. The issue was tackled on lite-xl#1332 but the solution introduced another issue when Lite XL was dynamically linked to the system lua. So we opted to tackle this by using function wrappers around the function pointers.
|
OK, looking good! Works for me. Only one nitpick, we should probably |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
As discussed with Adam on discord current Lite XL Lua Plugin API was not working on native plugins with more than 1 source file since imported symbols were not exposed to other unit files. The issue was tackled on lite-xl#1332 but the solution introduced another issue when Lite XL was dynamically linked to the system lua. So we opted to tackle this by using function wrappers around the function pointers.
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
As discussed with Adam on discord current Lite XL Lua Plugin API was not working on native plugins with more than 1 source file since imported symbols were not exposed to other unit files. The issue was tackled on lite-xl#1332 but the solution introduced another issue when Lite XL was dynamically linked to the system lua. So we opted to tackle this by using function wrappers around the function pointers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with Adam on discord current Lite XL Lua Plugin API was not working on native plugins with more than 1 source file since imported symbols were not exposed to other unit files. The issue was tackled on #1332 but the solution introduced another issue when Lite XL was dynamically linked to lua. So we opted to tackle this by using function wrappers around the function pointers.