Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make empty groups in regex.gmatch return their offset #1325

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Make empty groups in regex.gmatch return their offset #1325

merged 1 commit into from
Jan 13, 2023

Conversation

Guldoman
Copy link
Member

This makes regex.gmatch behave like string.gmatch.

@Guldoman
Make empty groups in regex.gmatch return their offset
8a5d9a1 
This makes `regex.gmatch` behave like `string.gmatch`.
@jgmdev
Copy link
Member

jgmdev commented Jan 13, 2023

Tested with the following sample code to compare:

for value in string.gmatch("test", "te()s") do
  print(value)
end

for value in regex.gmatch("te()s", "test") do
  print(value)
end

And now regex.gmatch returns same result as string.gmatch which in this case is 3

Another small variation, both print te:

for value in string.gmatch("test", "(te)()s") do
  print(value)
end

for value in regex.gmatch("(te)()s", "test") do
  print(value)
end

@Guldoman Guldoman merged commit b89dedf into lite-xl:master Jan 13, 2023
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Jan 16, 2023
@Guldoman @takase1121
Make empty groups in regex.gmatch return their offset (lite-xl#1325)
a82a820 
This makes `regex.gmatch` behave like `string.gmatch`.
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@Guldoman @takase1121
Make empty groups in regex.gmatch return their offset (lite-xl#1325)
6476c23 
This makes `regex.gmatch` behave like `string.gmatch`.
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Aug 19, 2023
@Guldoman @takase1121
Make empty groups in regex.gmatch return their offset (lite-xl#1325)
a9d8f12 
This makes `regex.gmatch` behave like `string.gmatch`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmdev jgmdev jgmdev approved these changes

Assignees
No one assigned
Labels
Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Guldoman @jgmdev