replace uses of SDL_Window with RenWindow #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Renwindow contains our instance of SDL_Window we can use this to simplify future logic to create separate window instances
|
Yeah; this makes sense. Better to have the no-cost abstraction, rather than passing around the original SDL_window in different places. Merging. |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Jan 16, 2023
Since Renwindow contains our instance of SDL_Window we can use this to simplify future logic to create separate window instances
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
Since Renwindow contains our instance of SDL_Window we can use this to simplify future logic to create separate window instances
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
Since Renwindow contains our instance of SDL_Window we can use this to simplify future logic to create separate window instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Renwindow contains our instance of SDL_Window we can use this to simplify future logic to create separate window instances.
Followed up by #1321
More work is needed to allow the creation of multiple windows and fully move it into Lua, but this is a sizable chunk that should be merged first.