Make dirwatch sorting compatible with what file_bisect expects
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of `a.filename < b.filename` is sometimes different from `system.path_compare(a.filename, a.type, b.filename, b.type)` which causes issues to `file_bisect`, as it expects the sorting to be done with `system.path_compare`.
|
LGTM, fixes the issue, and the diagnosis seems quite correct. Merging. |
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Jan 16, 2023
…ite-xl#1300) The result of `a.filename < b.filename` is sometimes different from `system.path_compare(a.filename, a.type, b.filename, b.type)` which causes issues to `file_bisect`, as it expects the sorting to be done with `system.path_compare`.
This was referenced Jan 29, 2023
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
…ite-xl#1300) The result of `a.filename < b.filename` is sometimes different from `system.path_compare(a.filename, a.type, b.filename, b.type)` which causes issues to `file_bisect`, as it expects the sorting to be done with `system.path_compare`.
takase1121
pushed a commit
to takase1121/lite-xl
that referenced
this pull request
Aug 19, 2023
…ite-xl#1300) The result of `a.filename < b.filename` is sometimes different from `system.path_compare(a.filename, a.type, b.filename, b.type)` which causes issues to `file_bisect`, as it expects the sorting to be done with `system.path_compare`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
a.filename < b.filenameis sometimes different fromsystem.path_compare(a.filename, a.type, b.filename, b.type)which causes issues tofile_bisect, as it expects the sorting to be done withsystem.path_compare.For example to trigger the issue, in an empty project dir run:
This also fixes #1260 (which was misdiagnosed).