Avoid drawing hidden text in DocView:draw_line_text
#1298
Conversation
Guldoman
changed the title
DocView:draw_line_textDocView:draw_line_text
|
Does this means ability to open a file with really long lines and not having the editor choke? |
|
It surely helps, but only on lines where the tokens aren't extremely long. |
|
As discussed on discord: It is probably better to do a quick clip check in the rencache for the first bit, to avoid the double width computation; also has the added benefit of just generally probably slimming down the rencache. We should know the current clip in C at the time of sending the command, so I can't think of a reason why that wouldn't work. |
Guldoman
force-pushed
the
PR_skip_draw_invisible_text
branch
from
ceae855 to
cfc9e77
Compare
The check was previously done with the window rect, so this will reduce a bit more the number of commands sent.
Guldoman
force-pushed
the
PR_skip_draw_invisible_text
branch
from
cfc9e77 to
19dec0f
Compare
|
Thanks to Adam's suggestions:
|
|
Looks good. Tested, and works fine. Still chokes on large files, but as you say, almost assuredly better, and don't see any rendering errors. Merging. |
* Stop drawing text past the `DocView` edge in `DocView:draw_line_text` * Don't add draw commands if they fall outside the latest clip The check was previously done with the window rect, so this will reduce a bit more the number of commands sent.
* Stop drawing text past the `DocView` edge in `DocView:draw_line_text` * Don't add draw commands if they fall outside the latest clip The check was previously done with the window rect, so this will reduce a bit more the number of commands sent.
With this PR, we no longer send hidden (tokenized) text to the renderer.
Non tokenized text or text tokenized as long strings is still a problem, which can be solved by splitting the tokenized text into smaller pieces.
Here there might be a performance impact caused by having to call
font:get_width, but this needs testing.