Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example settings to _overwrite_ an existing key binding #1270

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Add example settings to _overwrite_ an existing key binding #1270

merged 1 commit into from
Dec 27, 2022

Conversation

MFAshby
Copy link
Contributor

@MFAshby MFAshby commented Dec 27, 2022

Rationale:

  • I prefer to have ctrl+pageup/down bound to previous/next tabs, consistent with other editors and my web browser.
  • it took a little time to figure out that settings are additive by default, and it's necessary to pass a second parameter to overwrite an existing binding completely.
  • adding an example in the config file saves the next person some time :)

@adamharrison
Copy link
Member

This seems reasonable to me. Anyone have any objections?

@adamharrison adamharrison merged commit d4989d9 into lite-xl:master Dec 27, 2022
@MFAshby MFAshby deleted the doc_key_binding_overwrite branch December 28, 2022 09:16
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Jan 16, 2023
@MFAshby @takase1121
Add example settings to _overwrite_ an existing key binding (lite-xl#…
f0a1c02 
…1270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guldoman Guldoman Guldoman approved these changes

@jgmdev jgmdev jgmdev approved these changes

Assignees
No one assigned
Labels
Category: Lua Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MFAshby @adamharrison @jgmdev @Guldoman