Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Lua string length instead of relying on strlen #1262

Merged
merged 1 commit into from
Dec 26, 2022
Merged

Use Lua string length instead of relying on strlen #1262

merged 1 commit into from
Dec 26, 2022

Conversation

Guldoman
Copy link
Member

This allows us to render NULL byte sequences and not truncate strings that contain them.

Fixes #1261.

@Guldoman
Use Lua string length instead of relying on strlen
4e076c1 
This allows us to render `NULL` byte sequences and not truncate strings 
that contain them.
@jgmdev
Copy link
Member

jgmdev commented Dec 26, 2022

Tested, working, merging.

@jgmdev jgmdev merged commit c29b1c2 into lite-xl:master Dec 26, 2022
takase1121 pushed a commit to takase1121/lite-xl that referenced this pull request Jan 16, 2023
@Guldoman @takase1121
Use Lua string length instead of relying on strlen (lite-xl#1262)
132d82e 
This allows us to render `NULL` byte sequences and not truncate strings 
that contain them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lite-xl doesn't show characters after null bytes
2 participants
@Guldoman @jgmdev