detectindent: Limit subsyntax depth
#1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the native tokenizer is mature and merged into master we can re-introduce usage of the tokenizer for correctness since performance will no longer be an issue. But right now even with the performance fixes to tokenizer (like the consecutive spaces handling) Multiple plugins using it like rainbow parens, etc... will cause slowdowns. And sorry I closed by mistake while typing from phone xD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1247.
This limits to 5 the subsyntaxes depth
detectindentwill consider. This ought to be enough for anybody.This is an alternative to #1250.
As said in #1250, I still don't think this is the correct way to fix the issue because it's still using subsyntax info in places outside the actual subsyntax block, which can create "false negatives" and skip checking lines that would actually determine the indent.